Process --version Flag Directly
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
lindluni
changed the title
--version Flag Directly
theoludwig
approved these changes
Oct 4, 2022
|
Hi @divlo I've added the test, thanks for pointing this out! Appreciate the help! |
theoludwig
approved these changes
Oct 4, 2022
|
🎉 Congrats on getting your first pull request landed! |
|
Any chance we can get a Thank you for your help with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Directly process the
--versionflag as per: #263Which issue (if any) does this pull request address?
#263
Is there anything you'd like reviewers to focus on?
Processing the version flag directly in the
cli.jsmodule much like theeslintproject does: https://github.com/eslint/eslint/blob/main/lib/cli.js#L333