Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock down eslint plugin versions #825

Closed
feross opened this issue Mar 20, 2017 · 2 comments
Closed

Lock down eslint plugin versions #825

feross opened this issue Mar 20, 2017 · 2 comments
Labels
bug
Milestone
standard 10

Comments

@feross
Copy link
Member

feross commented Mar 20, 2017 •
edited

The latest v10 beta just started giving false positives related to JSX indentation. This is caused by a bug introduced in a patch version of eslint-plugin-react which we use to enforce JSX indentation.

Details here: jsx-eslint/eslint-plugin-react#1117

Not a big deal since this is still a beta version, but let's lock down the plugin versions before the final v10 is released. Let's use exact versions instead of loose with ~. I thought patch versions would be safe, but alas...
@feross feross added this to the standard v10 milestone Mar 20, 2017
@feross feross added the bug label Mar 20, 2017
@yannickcr
Copy link

v6.10.3 is now published and should fix the issue. Sorry for the inconvenience.

@feross
Copy link
Member Author

feross commented Mar 20, 2017

@yannickcr No problem. Thanks for maintaining an excellent plugin!

I'm happy to close this, and revisit if it's actually an issue in the future. No harm done.

@feross feross closed this as completed Mar 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
The Standard Project
Archived in project
Milestone
standard 10
Development

No branches or pull requests
2 participants
@yannickcr @feross