Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eslint-config-standard-jsx #1775

Merged
merged 2 commits into from Feb 3, 2022

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Feb 3, 2022

We need standard/eslint-config-standard-jsx#44 to fix #1548

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

Ensuring the ecmaVersion set in eslint-config-standard-jsx reflects the one set in eslint-config-standard

Which issue (if any) does this pull request address?

Fixes #1548

Is there anything you'd like reviewers to focus on?

Check that this actually fixes the problem.

@voxpelli voxpelli self-assigned this Feb 3, 2022
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a test case like we did inside eslint-config-standard to avoid regression.

@voxpelli
Copy link
Member Author

voxpelli commented Feb 3, 2022

Maybe we can add a test case like we did inside eslint-config-standard to avoid regression.

Good idea, added the very same, but adapted for the standard api. + I tested that it failed before the update of the jsx module and passed after the update 👍

@theoludwig theoludwig merged commit c120a60 into master Feb 3, 2022
@theoludwig theoludwig deleted the fix-top-level-await-support-2 branch February 3, 2022 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Parsing error: Cannot use keyword 'await' outside an async function
2 participants