Eliminate eslint-plugin-standard

[feross]

ATTENTION: If you're coming to this issue from the npm deprecation warning, here's what you need to know:

standard and eslint-config-standard version 16.0.0 and later no longer require eslint-plugin-standard to function. If you have this package in your package.json you can remove it with npm rm eslint-plugin-standard and save some disk space and install time :)

Here's the full v16.0.0 changelog: https://github.com/standard/standard/blob/master/CHANGELOG.md#1600---2020-10-28

---

We are only using one rule at this point: no-callback-literal. It would be nice to see if there's some way to eliminate the dependency and simplify the maintenance burden in some way.

[brodybits]

We are only using one rule at this point: no-callback-literal.

Couldn’t we replace it with handle-callback-err?

I would also like to say that this looks like an old JavaScript coding pattern that can be replaced by promises and async functions.

[feross]

handle-callback-err is about ensuring that the error is always handled in node.js-style callbacks. E.g. this is an error:

function loadData (err, data) {
    doSomething()
}

no-callback-literal ensures that when a node.js-style callback is actually called, the first argument is always null, undefined, or an Error object. E.g. this is an error:

cb('an error string')

[feross]

I opened an issue asking if ESLint wants to adopt no-callback-literal so we can deprecate eslint-plugin-standard: mysticatea/eslint-plugin-node#178

[feross]

I was able to PR the no-callback-literal rule into the eslint-plugin-node project: mysticatea/eslint-plugin-node#179

So, we can close this issue in standard 15 now :)

[voxpelli]

Posted a request to deprecate eslint-plugin-standard as a follow up to this thread: standard/eslint-plugin-standard#38

[feross]

@voxpelli I agree. Just released eslint-plugin-standard 5.0.0 and deprecated it.

[sQVe]

@feross This package is still listed as a peerDependency for https://github.com/standard/eslint-config-standard-with-typescript thought. So, basically still used.

[voxpelli]

@sQVe That peerDependency should be locked to 4.x then, or better, replaced there as well

[mmoussa-tbx]

What happened with this? I'm still having the issue @vitexikora reported in this comment #1316 (comment)

[voxpelli]

@mmoussa-tbx Nothing happens. This plugin has been superseded by other rules and neither eslint-config-standard or any other standard configs should be using it anymore.

If you can't remove eslint-plugin-standard without your setup failing, then that means one of two things:

1. You are referencing it yourself in your ESLint config (as in the comment you are referencing)
2. Another config you extend is referencing it

According to npm there are 1606 packages depending on the plugin: https://www.npmjs.com/package/eslint-plugin-standard All of them should be able to move on to the same rules that standard moved to.

Here's a reference of what happened with many of the rules:

• standard/no-callback-literal is replaced with node/no-callback-literal: Add no-callback-literal rule mysticatea/eslint-plugin-node#179
• standard/object-curly-even-spacing and standard/array-bracket-even-spacing were removed because they were found to be redundant: standard/eslint-config-standard@1bd2f52
• 'standard/computed-property-even-spacing': [2, 'even'],was replaced with 'computed-property-spacing': [2, 'never'],: standard/eslint-config-standard@532d389

[mmoussa-tbx]

@voxpelli thank you very much for the detailed explanation! 👍

We were still using in our .eslintrc file the standard/* rules defined in the deprecated eslint-plugin-standard

I just replaced these old rules with the ones in the eslint-config-standard rules file and is working good now!