Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo support #1182

Closed
Janpot opened this issue Aug 25, 2018 · 7 comments · Fixed by standard/standard-engine#228
Closed

monorepo support #1182

Janpot opened this issue Aug 25, 2018 · 7 comments · Fixed by standard/standard-engine#228

Comments

@Janpot
Copy link

Janpot commented Aug 25, 2018

I'd like to reopen #746
We're more than a year and a half later and monorepo structure becomes more and more prevalent. The issue can be easily worked around by ignoring **/node_modules/**. But I think it should be the standard behavior.

@LinusU
Copy link
Member

LinusU commented Aug 27, 2018

Ignoring **/node_modules/ out of the box seems fine by me 👍

@rstacruz
Copy link
Member

I second this, seems like a reasonable thing to do.

For background: the problem stems from a repo structure like so:

/
  packages/
    a/
      node_modules/
    b/
      node_modules/
    c/
      node_modules/

Running standard in the top-level can cause unnecessary traversions down into node_modules/. There's a workaround ☝️, but I agree it makes sense to be default behavior.

@LinusU
Copy link
Member

LinusU commented Aug 28, 2018

Pull request very welcome 🙌

@Janpot
Copy link
Author

Janpot commented Aug 28, 2018

Is this default provided by eslint? Maybe it should be a default in eslint?

@brodybits
Copy link
Contributor

I would personally favor consistency with eslint, assuming there is no good reason otherwise.

@Janpot
Copy link
Author

Janpot commented Aug 28, 2018

Yes, that makes sense. I've been digging through their tickets and found this PR eslint/eslint#10092
Not sure whether they're not open to expand the default, or whether it was just easier to document than fix

@feross
Copy link
Member

feross commented Oct 29, 2020

This issue should be fixed in standard v16 because of an improvement to standard-engine.

It would be great if someone could test this on your project to confirm, once standard 16 is released.

UPDATE: just tested it and it works!

@feross feross closed this as completed Oct 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants