fix: subject fixed failure to propgate extension rules present in standard #583
Conversation
|
🙌 Thanks for opening this pull request! You're awesome. |
6XGate
force-pushed
the
feature/propagate-all-extension-rules
branch
from
8f9035f
to
75a9d51
Compare
6XGate
changed the title
There was a problem hiding this comment.
Looks good to me! 👍
But I don't know much of this codebase, so I'll let @mightyiam decide to approve and merge this PR.
Thanks for your contribution! @6XGate
package.json
Outdated
| "@typescript-eslint/parser": "^4.0.0", | ||
| "@typescript-eslint/parser": "^4.15.0", | ||
| "eslint-config-standard": "^16.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@typescript-eslint/eslint-plugin": ">=4.15.0", | ||
| "eslint": ">=7.12.1", | ||
| "eslint-plugin-import": ">=2.22.1", | ||
| "eslint-plugin-node": ">=11.1.0", | ||
| "eslint-plugin-promise": ">=4.2.1", | ||
| "typescript": ">=3.9", | ||
| "@typescript-eslint/eslint-plugin": ">=4.0.1" | ||
| "typescript": ">=3.9" | ||
| }, | ||
| "devDependencies": { | ||
| "@commitlint/cli": "12.1.4", | ||
| "@commitlint/config-conventional": "12.1.4", | ||
| "@commitlint/travis-cli": "12.1.4", | ||
| "@types/eslint": "7.2.13", | ||
| "@types/node": "14.17.3", | ||
| "@typescript-eslint/eslint-plugin": "4.0.1", | ||
| "@typescript-eslint/eslint-plugin": "4.15.0", |
There was a problem hiding this comment.
I'd like dependency upgrades in a separate PR, even if they are necessary for this one, please.
There was a problem hiding this comment.
PR available there: #592
There was a problem hiding this comment.
#592 failed checks due to one of the dependency constraints changing in standard that this code base originally take into account. I fixed it here, so hope that won't be an issue.
There was a problem hiding this comment.
Actually, it will be fixed with #590.
|
@6XGate sorry for not reviewing your PR until now, if we review it, will you proceed with it? |
|
proceed with it? I'm not sure what you mean by that. |
|
@6XGate yes. If we review it will you follow through with it with it? It's been a while. That's why we ask. |
|
Sure, I'll give a try at it again soon. |
|
I'm happy to hear that, @6XGate . But we haven't reviewed it yet, so don't spend time yet. Now that I know you're willing to go through with it, we'll review it for you. Not before August though. |
6XGate
force-pushed
the
feature/propagate-all-extension-rules
branch
from
37f7931
to
e1c3a25
Compare
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. Closes #582, closes #583. Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. Closes #582, closes #583. Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
## [23.0.0](v22.0.0...v23.0.0) (2022-09-13) ### ⚠ BREAKING CHANGES * add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. ### Features * use all typescript-eslint equivalents ([1e8764d](1e8764d)), closes [#582](#582) [#583](#583) ### CI * continuous delivery ([971c680](971c680)), closes [#840](#840) ### Build system / dependencies * renovate automergeMinor github actions ([02dde9d](02dde9d)), closes [#910](#910)
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Ensured that all
@typescript-eslintrules are propagated if they appear in the Standard JS configuration.Which issue (if any) does this pull request address?
#582 Some upstream standard rules are not properly propagated to their @typescript-eslint version
Is there anything you'd like reviewers to focus on?