Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require-array-sort-compare ignoreStringArrays #359

Merged
merged 1 commit into from Jan 15, 2021

Conversation

mightyiam
Copy link
Owner

No description provided.

@request-info
Copy link

request-info bot commented Jun 11, 2020

👋 We would appreciate it if you could provide us with more information about this issue.

@mightyiam
Copy link
Owner Author

I feel that native string sorting is sometimes useful and there's not enough justification to remind people that it might not be what they're looking for. Not with a rule.

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/require-array-sort-compare.md#ignorestringarrays

@mightyiam mightyiam requested a review from LinusU June 11, 2020 10:09
@mightyiam
Copy link
Owner Author

Seems to require a rebase?

@theoludwig
Copy link
Contributor

theoludwig commented Jan 15, 2021

Yep, we need to squash maybe, so commitlint is happy.
I updated the branch with master but commitlint doesn't like that.

EDIT: I squash and merge to master (also deleted the branch) since there were 2 approvals and everything were fine.

@theoludwig theoludwig merged commit 95fcb7c into master Jan 15, 2021
@theoludwig theoludwig deleted the ignoreStringArrays branch January 15, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants