Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Ensure module.id is string #681

Closed
Closed
Ensure module.id is string#681
Labels
bug
@tunnckoCore

Description

@tunnckoCore
tunnckoCore
opened on Nov 29, 2018 · edited by tunnckoCore

The one way is to get fixed in the webpack as mention in vercel/ncc#21 (comment)

Another way is to get fixed here. At best at the both places.

Want a PR to make that here https://github.com/standard-things/esm/blob/master/esm.js#L29?

Activity

jdalton
added
bug
on Nov 30, 2018
jdalton
closed this as completedin 3e8ca01on Nov 30, 2018
jdalton

jdalton commented on Nov 30, 2018

@jdalton
jdalton
on Nov 30, 2018
Member

Thanks for the report @tunnckoCore!

tunnckoCore

tunnckoCore commented on Nov 30, 2018

@tunnckoCore
tunnckoCore
on Nov 30, 2018 · edited by tunnckoCore
Author

Great! : ) Looking ahead for the next release.

tunnckoCore
mentioned this on Nov 30, 2018
jdalton
added a commit that references this issue on Nov 30, 2018

Ensure module.id is a string. [closes #681]

3817edc
jdalton
mentioned this on Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jdalton@tunnckoCore

        Issue actions
          Ensure module.id is string · Issue #681 · standard-things/esm