Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use doc_cfg and --all-features for documentation #13

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Use doc_cfg and --all-features for documentation #13

merged 1 commit into from
Jul 1, 2022

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented Jun 30, 2022

Otherwise it is easy to miss that tokio is also supported.

@nagisa
Use doc_cfg and --all-features for documentation
2e865c8 
Otherwise it is easy to miss that `tokio` is also supported.
@nagisa nagisa force-pushed the nagisa/polish-docs-a-little branch from c3a9209 to 2e865c8 Compare June 30, 2022 15:28
Ekleog
Ekleog approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like (the fact that we need) doc_cfg (because io me it should be default behavior), but LGTM anyway :)

@lovesegfault lovesegfault merged commit 69994c1 into master Jul 1, 2022
@lovesegfault lovesegfault deleted the nagisa/polish-docs-a-little branch July 1, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagisa @Ekleog @lovesegfault