Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Operator changes for multi-arch #477

Closed
4 tasks
Maleware opened this issue Sep 19, 2022 · 4 comments
Closed
4 tasks

Spike: Operator changes for multi-arch #477

Maleware opened this issue Sep 19, 2022 · 4 comments

Comments

@Maleware
Copy link
Contributor

Maleware commented Sep 19, 2022

As an Example, we will spike changes for all operators on the example of Kafka.

As long as the Image-Selection-ADR is not implemented (ISSUE TBD), we will show how we need to change the operator.

For the spike, we gonna change things hard-coded, for a more elaborated GH-Action, the ADR023 must be implemented.

Changes for image dependencies:

  • rust/operator/src/kafka_contoller.rs
    • stackable/kafka:{} -> stackable-experimental/kafka:{}
    • stackable/tools: -> stackable-experimental/tools: 2x
    • stackable/edenhill/kcat:1.7.0" -> stackable-experimental/edenhill/kcat:1.7.0"
      For this to work, a multi-arch-image of those dependencies has to present. Therefore we change those paths

Changes in Cargo.toml:

  • rust/crd/Cargo.toml
    • OpenSSL: openssl = { version = "0.10.41", features = ["vendored"] }

Makefile:

  • Enable buildx in makefile, proposed option:
    docker-build-multi:
    docker buildx create --name builder --use
    docker buildx build --force-rm --build-arg VERSION=${VERSION} -t "docker.stackable.tech/stackable-experimental/kafka-operator:${VERSION}" -f docker/Dockerfile --platform linux/arm64,linux/amd64 --push .
    docker buildx rm builder

Dockerfile:

  • stackable/ubi8-rust-builder -> stackable-experimental/ubi8-rust-builder
    For this to work a updated Rust-builder which is already prepared for multi-arch is necessary. At the stackable-experimental repository, there is already the correct one present. This is build as a multi-arch-image and was made from the multi-arch-branch

Working-Branches:

@vsupalov
Copy link
Contributor

vsupalov commented Nov 3, 2022

The image selection feature implementation for kafka-operator is being worked on in #482 as part of the ADR implementation stackabletech/operator-rs#470

@vsupalov
Copy link
Contributor

vsupalov commented Nov 3, 2022

Integrating the new image selection ADR and moving away from a hard-coded tools image is explored in #504

@vsupalov
Copy link
Contributor

vsupalov commented Nov 3, 2022

The "completed" state of this spike will be a union of:

@vsupalov
Copy link
Contributor

vsupalov commented Aug 7, 2023

Retiring this spike, as it is outdated.

@vsupalov vsupalov closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants