Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recent changes #23

Merged
merged 1 commit into from Jul 3, 2022
Merged

Apply recent changes #23

merged 1 commit into from Jul 3, 2022

Conversation

wborn
Copy link
Contributor

@wborn wborn commented Jun 27, 2022

This is the result of "npm run build && npm run format", see:

"pre-commit": "npm run build && npm run format",

Fixes #18

This is the result of "npm run build && npm run format", see:

https://github.com/stCarolas/setup-maven/blob/417e1a9899611c0350621d1fb0c2770f35105c69/package.json#L37

Fixes stCarolas#18

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Contributor Author

wborn commented Jun 27, 2022

It would also help whenever a new release is made, the major tag (currently v4) is updated... then everyone using the action can use,

uses: stCarolas/setup-maven@v4

instead which makes it a lot easier to use the latest action version if you use it in many repos. 🙂

@wborn
Copy link
Contributor Author

wborn commented Jun 27, 2022

I added a tag to my own repo so you can test these changes with:

uses: wborn/setup-maven@v4

It seems to work and pick up the new URL of #22 as can be seen in this build.

@stCarolas stCarolas merged commit 021645c into stCarolas:master Jul 3, 2022
@wborn wborn deleted the update-lib branch July 3, 2022 11:57
@slawekjaranowski
Copy link

@stCarolas new release will be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated distribution
3 participants