Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call function.currentVersion to work around CDK issue #1001

Open
thdxr opened this issue Nov 5, 2021 · 3 comments · May be fixed by #1020
Open

Call function.currentVersion to work around CDK issue #1001

thdxr opened this issue Nov 5, 2021 · 3 comments · May be fixed by #1020
Labels
bug Something isn't working

Comments

@thdxr
Copy link
Contributor

thdxr commented Nov 5, 2021 •
edited

See this issue: aws/aws-cdk#13731 (comment)

We should automatically call function.currentVersion if function.currentVersionOptions exists

Requests
@thdxr thdxr added this to Triage in Backlog via automation Nov 5, 2021
@thdxr thdxr moved this from Triage to Ready in Backlog Nov 5, 2021
@junaway junaway self-assigned this Nov 9, 2021
@junaway
Copy link
Contributor

junaway commented Nov 9, 2021

  • Research: How to test for provisioned concurrency
  • Reaserch: Where to apply fix from aws/aws-cdk#13731 (comment) in sst.Function
  • Implement: Fix from above.
  • Test: Lambda with provisioned concurrency.

@junaway junaway linked a pull request Nov 9, 2021 that will close this issue
Open
@junaway junaway added Status: In Progress bug Something isn't working and removed Help Needed labels Nov 9, 2021
@pabacham
Copy link

any updates here?

@fwang fwang removed the Help Needed label Feb 15, 2022
@fwang fwang removed this from Ready in Backlog Feb 21, 2022
@SamStephens
Copy link

I've created aws/aws-cdk#23002 to fix the root issue in the CDK (note I'm not a user of your project, I just saw this during my searches and thought you'd appreciate being able to track if the root cause is fixed and you can remove your workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Api: Call function.currentVersion to work around CDK issue junaway/serverless-stack
5 participants
@fwang @thdxr @SamStephens @pabacham @junaway