Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes there's no value loaded when an animationFrame is requested #34

Open
jwoertink opened this issue Sep 29, 2022 · 0 comments · May be fixed by #38
Open

Sometimes there's no value loaded when an animationFrame is requested #34

jwoertink opened this issue Sep 29, 2022 · 0 comments · May be fixed by #38

Comments

@jwoertink
Copy link

This may be related to mobile browser issues, but I have about 7k bugsnag reports of this._inputRef.value is undefined and Cannot read properties of undefined (reading 'focus') which I was able to trace back to this line.

ninja-keys/src/ninja-header.ts

Line 124 in 52ccc0d

requestAnimationFrame(() => this._inputRef.value!.focus());

I'm not quite sure how this part works, but my guess is maybe a guard clause is needed to ensure _inputRef exists and is the correct type?
jwoertink added a commit to jwoertink/ninja-keys that referenced this issue Dec 14, 2022
@jwoertink
Adds a guard clause for if the _inputRef doesn't exist when the anima…
46b349b 
…tionFrame is executed. Fixes ssleptsov#34
@jwoertink jwoertink linked a pull request Dec 14, 2022 that will close this issue
Open
@jwoertink jwoertink mentioned this issue Jan 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a guard clause for _inputRef jwoertink/ninja-keys
1 participant
@jwoertink