Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] close() on ZipFile to close previously returned InputStream´s #327

Closed
nils91 opened this issue Jun 12, 2021 · 3 comments
Closed

[Feature Request] close() on ZipFile to close previously returned InputStream´s #327

nils91 opened this issue Jun 12, 2021 · 3 comments
Assignees
@srikanth-lingala
Labels
new-feature New feature or request resolved
Projects
Zip4j

Comments

@nils91
Copy link

nils91 commented Jun 12, 2021 •
edited

Hi,

as far as i can tell there´s currently no way to close all InputStreams returned by getInputStream() on ZipFile at once, each stream needs to be closed individually. A close() on the ZipFile class itself would help to ensure that all input streams are closed and the zip file is 'closed'.
The java.util.ZipFile class has a close: https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/zip/ZipFile.html#close()

Thanks!
srikanth-lingala added a commit that referenced this issue Jun 21, 2021
@srikanth-lingala
#327 Implement close on ZipFile
20364a0
@srikanth-lingala srikanth-lingala self-assigned this Jun 21, 2021
@srikanth-lingala srikanth-lingala added the new-feature New feature or request label Jun 21, 2021
@srikanth-lingala srikanth-lingala added this to To do in Zip4j via automation Jun 21, 2021
@srikanth-lingala srikanth-lingala moved this from To do to Review in Zip4j Jun 21, 2021
@srikanth-lingala
Copy link
Owner

Feature implemented. I will include this in the next release.

@nils91 nils91 closed this as completed Jun 22, 2021
Zip4j automation moved this from Review to Done Jun 22, 2021
Zip4j automation moved this from Done to To do Jun 22, 2021
@srikanth-lingala
Copy link
Owner

@nils91 Please leave this issue open. I will close this once the release is done.

srikanth-lingala added a commit that referenced this issue Jun 25, 2021
@srikanth-lingala
#327 Implement Closeable interface on ZipFile
f290b66
srikanth-lingala added a commit that referenced this issue Jun 25, 2021
@srikanth-lingala
#327 Fix bug to close inputstreams when ZipFile is closed multiple times
861f03e
@srikanth-lingala
Copy link
Owner

Feature added in v2.9.0 released today.

Zip4j automation moved this from To do to Done Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
new-feature New feature or request resolved
Projects
Zip4j
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srikanth-lingala @nils91