Fix #337 issue #338
Merged
Fix #337 issue #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
approved these changes
Mar 6, 2018
|
Make revert to being sure it is not my fault. ¯_(ツ)_/¯ |
|
The main problem is fixed now: https://github.com/src-d/engine/pull/340 . Can you rebase to make tests pass please? |
|
ok, done. So, I think we should make PR to change version here: https://github.com/src-d/infrastructure/blob/master/dockerfiles/spark/Dockerfile#L4 and ask @rporres to deploy it on our cluster. |
|
Shall we merge this guy and make a release to publish new engine-jupyter image? |
|
@bzz, it is not so important for my current issues, and definitely not urgent, but at some point yes, we should publish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix https://github.com/src-d/engine/issues/337 issue, all described there.