Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logrus colors in windows are broken #187

Closed
se7entyse7en opened this issue Jan 3, 2019 · 1 comment
Closed

Logrus colors in windows are broken #187

se7entyse7en opened this issue Jan 3, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@se7entyse7en
Copy link
Contributor

se7entyse7en commented Jan 3, 2019 •
edited

When working on #45 I noticed that the colors of the logs written with logrus are not rendered correctly on Windows (I tried Windows 10).

screenshot 2019-01-03 at 15 09 01

By doing a quick search I found that this commit in logrus should fix the coloring on windows and it is available in v1.2.0. Nevertheless there's also this PR that has not been released yet, but that disables text colouring for Windows completely.

Here are other related PRs.

Maybe we could wait for the next release of logrus and update the dependency.
@se7entyse7en se7entyse7en added the bug Something isn't working label Jan 3, 2019
@smacker
Copy link
Contributor

smacker commented Mar 29, 2019

we are using v1.4.0 now and this was fixed.

@smacker smacker closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smacker @se7entyse7en