Short list not tokenized correctly in control structures without braces #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout braces
Originally reported in sirbrillig/phpcs-variable-analysis 263.
When the short list syntax would be used as the first contents within a control structure without braces, the square brackets would be tokenized as plain square brackets, not as short array brackets.
```php
if ( true )
[ $a ] = [ 'hi' ]; // The first `[` in this line was tokenized incorrectly.
return $a ?? '';
```
Fixed now by checking whether the preceding parenthesis closer has an owner and if that owner could be a scope owner.
Includes unit tests.
Includes updating the data providers to use named data sets to allow for easier debugging.
sirbrillig
added a commit
to sirbrillig/phpcs-variable-analysis
that referenced
this pull request
Aug 12, 2022
sirbrillig
added a commit
to sirbrillig/phpcs-variable-analysis
that referenced
this pull request
Aug 13, 2022
* Add tests for inline if list destructuring * Support treating T_OPEN_SQUARE_BRACKET as a list opener * Add test for foreach with list destructure * Better differentiate between list destructuring and array access * Use the same technique for finding list assignments as phpcs might See squizlabs/PHP_CodeSniffer#3632
gsherwood
changed the title
|
Thank you |
jrfnl
deleted the
feature/tokenizer-php-bug-fix-short-list-in-non-braced-control-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported in sirbrillig/phpcs-variable-analysis#263.
When the short list syntax would be used as the first contents within a control structure without braces, the square brackets would be tokenized as plain square brackets, not as short array brackets.
Fixed now by checking whether the preceding parenthesis closer has an owner and if that owner could be a scope owner.
Includes unit tests.
Includes updating the data providers to use named data sets to allow for easier debugging.