Ignore annotations are broken on PHP 8.0 #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/php-8-compat-bugfix-ignore-annotations
branch
from
028f868
to
3bc9ebf
Compare
|
I was bit with this too. |
|
@Ayesh Yup, it's a nasty one. At least it's now mentioned in the changelog (after I made a remark about it). |
jrfnl
force-pushed
the
feature/php-8-compat-bugfix-ignore-annotations
branch
from
3bc9ebf
to
4877700
Compare
A very recent change in PHP 8.0 changes the possible return values of the `substr()` function from: > Pre-PHP 8: > Returns the extracted part of string; or FALSE on failure, or an empty string. > PHP 8-RC1: > Returns the extracted part of string; or an empty string. This is an insidious change as basically all code (strict) checking the return value of `substr()` against `false` will now be broken. Checking the return value with `empty()` will fix this in a cross-version compatible manner as it allows for both `false` as well as an empty string being returned. This change broke the ignore annotations as implemented in PHPCS. The existing unit tests for the ignore annotations cover this change. Includes removing some unnecessary, duplicate function calls to `substr()`. Ref: php/php-src#6182
gsherwood
changed the title
|
I'm very thankful you found and fixed this. Bit of a rough last minute change. |
|
Well, at least there were tests in place to find it quickly ;-) From a PHP Core perspective, I do think it is a good change as it makes the function return type of these functions more consistent going forward, but yes, BC-break-wise it's nasty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very recent change in PHP 8.0 changes the possible return values of the
substr()function from:This is an insidious change as basically all code (strict) checking the return value of
substr()againstfalsewill now be broken.Checking the return value with
empty()will fix this in a cross-version compatible manner as it allows for bothfalseas well as an empty string being returned.This change broke the ignore annotations as implemented in PHPCS.
The existing unit tests for the ignore annotations cover this change.
Includes removing some unnecessary, duplicate function calls to
substr().Ref: php/php-src#6182