Squiz/PSR12/OperatorSpacing: bug fix - unary plus/minus in arrow function return #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion return A plus/minus directly after the arrow of an arrow function, will always be a unary plus/minus and should therefore be ignored by these sniffs. Includes unit tests. Includes two additional simplifications: * `T_DOUBLE_ARROW` is already part of the `Tokens::$assignmentTokens` array, so doesn't need to be added separately. * The cast tokens array was incomplete (missing `T_BINARY_CAST`) and can be replaced by the more complete `Tokens::$castTokens` array anyhow. Fixes 3043
|
@gsherwood As there are already three other fixes for the operator spacing sniffs in |
|
Thanks for the fix and general sniff cleanup |
jrfnl
deleted the
feature/3043/psr12-operatorspacing-bug-with-arrow-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plus/minus directly after the arrow of an arrow function, will always be a unary plus/minus and should therefore be ignored by these sniffs.
Includes unit tests.
Includes two additional simplifications:
T_DOUBLE_ARROWis already part of theTokens::$assignmentTokensarray, so doesn't need to be added separately.T_BINARY_CAST) and can be replaced by the more completeTokens::$castTokensarray anyhow.Fixes #3043