Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squiz.Arrays.ArrayDeclaration false positive when using type casting #3059

Closed
morozov opened this issue Aug 29, 2020 · 0 comments · Fixed by #3061
Closed

Squiz.Arrays.ArrayDeclaration false positive when using type casting #3059

morozov opened this issue Aug 29, 2020 · 0 comments · Fixed by #3061

Comments

@morozov
Copy link
Contributor

morozov commented Aug 29, 2020

Describe the bug
A false-positive rule violation is detected that conflicts with another rule and prevents auto-fixing.

Code sample

<?php

function test()
{
    return [
        (object) [
            'a' => 'foo',
            'b' => 1,
        ],
    ];
}

Custom ruleset
None.

To reproduce
Steps to reproduce the behavior:

  1. Run phpcs -s --standard=Squiz --sniffs=Squiz.Arrays.ArrayDeclaration,Generic.Formatting.SpaceAfterCast fail.php
FILE: /home/morozov/Projects/phpcs-playground/fail.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 6 | ERROR | [x] The first value in a multi-value array must be on a new line
   |       |     (Squiz.Arrays.ArrayDeclaration.ValueNoNewline)
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Time: 47ms; Memory: 8MB
  1. Run phpcbf --standard=Squiz --sniffs=Squiz.Arrays.ArrayDeclaration,Generic.Formatting.SpaceAfterCast fail.php
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
/home/morozov/Projects/phpcs-playground/fail.php     FAILED TO FIX
----------------------------------------------------------------------
A TOTAL OF 0 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------
PHPCBF FAILED TO FIX 1 FILE
----------------------------------------------------------------------

Time: 124ms; Memory: 8MB

Expected behavior
No error is reported.

Versions (please complete the following information):

  • OS: Linux
  • PHP: 7.4.9
  • PHPCS: 3.5.6
  • Standard: Squiz
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation Sep 21, 2020
@gsherwood gsherwood added this to the 3.5.7 milestone Sep 21, 2020
@gsherwood gsherwood changed the title Squiz.Arrays.ArrayDeclaration false positive and conflict with Generic.Formatting.SpaceAfterCast Squiz.Arrays.ArrayDeclaration false positive when using type casting Sep 21, 2020
PHPCS v3 Development automation moved this from Idea Bank to Ready for Release Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PHPCS v3 Development
Ready for Release
Development

Successfully merging a pull request may close this issue.

2 participants