Add serialize and unserialize to list of known magic methods #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsherwood
requested changes
Jul 22, 2020
| 'construct' => true, | ||
| 'destruct' => true, | ||
| 'call' => true, | ||
| 'callstatic ' => true, |
There was a problem hiding this comment.
A space character has been inserted at the end of the string callstatic, which will cause this sniff to produce errors for this magic method.
| 'construct' => true, | ||
| 'destruct' => true, | ||
| 'call' => true, | ||
| 'callstatic ' => true, |
There was a problem hiding this comment.
A space character has been inserted at the end of the string callstatic, which is causing the failing unit tests.
gsherwood
approved these changes
Jul 23, 2020
|
Thanks a lot for fixing that up |
|
Thanks for fixing up that issue, and thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
serializeandunserializeto list of known magic methods and fixes #3029. I also updated list a bit to match the same order as list in PHP documentation to make comparing lists in the future easier.