Markdown generator does not output headings correctly #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
approved these changes
May 22, 2020
|
@gsherwood Could you check it, please? |
|
@gsherwood any comments? |
o5
added a commit
to slimapi/coding-standard
that referenced
this pull request
Jul 17, 2020
…nsole, slimapi/slimapi Used forked version of PHP_CodeSniffer, waiting for: * squizlabs/PHP_CodeSniffer#2967 * squizlabs/PHP_CodeSniffer#3017
|
I went to merge this and realised there is a hard-coded unix newline here. The PHP_EOL constant is used throughout doc generation to ensure the newline characters match the OS being used, so this should be used for consistency. But I realise it's been 2 months, so I can make that change if you don't have time. |
gsherwood
changed the title
|
Thanks a lot for that change, and for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Tested in GitHub, GitLab, Bitbucket and PHPStorm Markdown Plugin.