New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PEAR\Commenting\FunctionComment] Improve check for special method and add an option #2925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests with different values for the new property.
@jrfnl Sure ! But do I override an array property ? |
@VincentLanglet See: #1999 |
Oh and I should probably also point you to this open issue: #2228 Not sure you are aware of it and it will affect the new property you are adding. |
Hi @gsherwood ! Are you interested by this PR ? :) |
I haven't had time to look at this at all. It's still on my list to review, but will not be added in 3.5.6. |
Hi ! I fixed the conflict @gsherwood Can I expect to see this PR in 3.5.9 ? :) |
Sorry this took so long - the PHP8 work has been a big distraction. Thanks a lot of this change. It's going to be in 3.6.0. The documentation is here: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#pearcommentingfunctioncomment |
This would close #2924
Report
as an error.
And allow to override the list of specialMethod, in order to add others or to disallow this special behaviour by passing an empty array.