Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAR.Functions.FunctionCallSignature false positive for array of functions #2877

Closed
VincentLanglet opened this issue Feb 22, 2020 · 0 comments · Fixed by #2941
Closed

PEAR.Functions.FunctionCallSignature false positive for array of functions #2877

VincentLanglet opened this issue Feb 22, 2020 · 0 comments · Fixed by #2941

Comments

@VincentLanglet
Copy link
Contributor

The following code

$a = ['a' => function ($b) { return $b; }];
$a['a']( 1 );

Return no error for the extra space after the opening and before the closing parentheses.

Since the ( is correctly ignored in the Generic.WhiteSpace.ArbitraryParenthesesSpacing, this should be handle in the FunctionCallSignatureSniff.

@VincentLanglet VincentLanglet changed the title [FunctionCallSignatureSniff] False positive [FunctionCallSignatureSniff] False positive for array of function Feb 22, 2020
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation Mar 9, 2020
@gsherwood gsherwood added this to the 3.5.6 milestone Mar 9, 2020
@gsherwood gsherwood changed the title [FunctionCallSignatureSniff] False positive for array of function PEAR.Functions.FunctionCallSignature false positive for array of functions Jun 22, 2020
PHPCS v3 Development automation moved this from Idea Bank to Ready for Release Jun 22, 2020
gsherwood added a commit that referenced this issue Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PHPCS v3 Development
Ready for Release
Development

Successfully merging a pull request may close this issue.

2 participants