Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable error when using Info report #2853

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Feb 4, 2020

This partially reverts the change made to this particular file in e9ebf52

The floor( $countWidth / 3) was causing an undefined variable notice as the original definition of the variable was removed.

This partially reverts the change made to this particular file in e9ebf52

The `floor( $countWidth / 3)` was causing an _undefined variable_ notice.
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation Feb 9, 2020
@gsherwood gsherwood added this to the 3.5.5 milestone Feb 9, 2020
@gsherwood gsherwood changed the title Report/Info: fix "undefined variable" error. Undefined variable error when using Info report Feb 9, 2020
gsherwood added a commit that referenced this pull request Feb 9, 2020
@gsherwood gsherwood merged commit dfc265d into squizlabs:master Feb 9, 2020
PHPCS v3 Development automation moved this from Idea Bank to Ready for Release Feb 9, 2020
@jrfnl jrfnl deleted the feature/info-report-undefined-var branch February 9, 2020 22:51
@gsherwood
Copy link
Member

Thanks a lot for fixing this

@jrfnl
Copy link
Contributor Author

jrfnl commented Feb 9, 2020

You're welcome.

tobias-trozowski pushed a commit to tobias-trozowski/PHP_CodeSniffer that referenced this pull request Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PHPCS v3 Development
Ready for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants