File::getMethodParameters() setting typeHintEndToken for vars with no type hint #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following code sample:
```php
function foo( ?bool $a, $b ) {}
```
In the resulting array, the second parameter `$b` will have the 'type_hint_end_token' set to the stack pointer for the end of the type declaration for `$a`.
Caused by the `$typeHintEndToken` not being reset for the next parameter.
I've re-ordered the variable reset now to be the same as the order used for the initial variable declarations before the loop to make it more obvious.
While not necessarily a bug, the `$currVar` variable was also not being reset. That's also been fixed now.
I've not added a unit test as the existing tests do not check the token positions in the array.
gsherwood
changed the title
$typeHintEndToken
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code sample:
In the resulting array, the second parameter
$bwill have the'type_hint_end_token'index set to the stack pointer for the end of the type declaration for$a, instead of it being the expectedfalse.Caused by the
$typeHintEndTokennot being reset for the next parameter.I've re-ordered the variable reset now to be the same as the order used for the initial variable declarations before the loop to make it more obvious.
While not necessarily a bug, the
$currVarvariable was also not being reset. That's also been fixed now.I've not added a unit test as the existing tests do not check the token positions in the array.