Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR12.Files.FileHeader locks up when file ends with multiple inline comments #2676

Closed
gsherwood opened this issue Oct 30, 2019 · 1 comment
Closed

PSR12.Files.FileHeader locks up when file ends with multiple inline comments #2676

gsherwood opened this issue Oct 30, 2019 · 1 comment
Labels
Type: bug
Projects
PHPCS v3 Development
Milestone
3.5.3

Comments

@gsherwood
Copy link
Member

If you add another comment below // Do nothing (716b619), the same issue appear, at least for me.

<?php
// Do nothing
// Do nothing again

Originally posted by @ttrig in #2619 (comment)
@gsherwood gsherwood added this to Idea Bank in PHPCS v3 Development via automation Oct 30, 2019
@gsherwood gsherwood added this to the 3.5.3 milestone Oct 30, 2019
gsherwood added a commit that referenced this issue Oct 30, 2019
@gsherwood
Fixed bug #2676 : PSR12.Files.FileHeader locks up when file ends with…
b1c7d88 
… multiple inline comments
@gsherwood
Copy link
Member Author

@ttrig thanks for reporting this additional issue. This has been fixed in master and will be in 3.5.3.

PHPCS v3 Development automation moved this from Idea Bank to Ready for Release Oct 30, 2019
@gsherwood gsherwood mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
PHPCS v3 Development
Ready for Release
Milestone
3.5.3
Development

No branches or pull requests
1 participant
@gsherwood