diff --git a/src/Standards/Squiz/Sniffs/CSS/DuplicateClassDefinitionSniff.php b/src/Standards/Squiz/Sniffs/CSS/DuplicateClassDefinitionSniff.php index 73c7e4f322..0e2d6a6560 100644 --- a/src/Standards/Squiz/Sniffs/CSS/DuplicateClassDefinitionSniff.php +++ b/src/Standards/Squiz/Sniffs/CSS/DuplicateClassDefinitionSniff.php @@ -88,6 +88,7 @@ public function process(File $phpcsFile, $stackPtr) $name = trim($name); $name = str_replace("\n", ' ', $name); $name = preg_replace('|[\s]+|', ' ', $name); + $name = preg_replace('|\s*/\*.*\*/\s*|', '', $name); $name = str_replace(', ', ',', $name); $names = explode(',', $name); diff --git a/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css b/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css index ebd466e416..6b7375da76 100644 --- a/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css +++ b/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css @@ -71,3 +71,33 @@ .foo /* any comment */ { color: red; } + +/* print comment */ +@media print { + /* any comment */ + td { + } + + /* any comment */ + img { + } + + /* any comment */ + td { + } +} + +@media handheld /* handheld comment */ +{ + td /* any comment */ + { + } + + img /* any comment */ + { + } + + td /* any comment */ + { + } +} diff --git a/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.php b/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.php index 48702859b1..2a95971b05 100644 --- a/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.php +++ b/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.php @@ -26,9 +26,11 @@ class DuplicateClassDefinitionUnitTest extends AbstractSniffUnitTest public function getErrorList() { return [ - 9 => 1, - 29 => 1, - 57 => 1, + 9 => 1, + 29 => 1, + 57 => 1, + 86 => 1, + 101 => 1, ]; }//end getErrorList()