Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overflow for notes in Mermaid sequence diagrams in Firefox #5010

Closed
4 tasks done
bertrand-sb opened this issue Feb 8, 2023 · 1 comment
Closed
4 tasks done
Labels
bug Issue reports a bug upstream Issue must be taken upstream

Comments

@bertrand-sb
Copy link

Context

No response

Bug description

In Mermaid sequence diagrams, notes over a single participant can overflow but only in Firefox:

mermaid_firefox

The same in Chrome:

mermaid_chrome

Note that Firefox is fine in Mermaid's live editor:

mermaid_live_editor_firefox

Related links

Reproduction

example.zip

Steps to reproduce

I have a single docs/index.md file with the following content:

```mermaid
sequenceDiagram
    participant A
    participant B
    A->>B: hello

    note over A: Note with overflow but only in Firefox.
```

Configuration:

site_name: My Docs

theme:
  name: material

markdown_extensions:
  - pymdownx.superfences:
      custom_fences:
        - name: mermaid
          class: mermaid
          format: !!python/name:pymdownx.superfences.fence_code_format

Versions:

  • mkdocs: 1.4.2
  • mkdocs-material: 9.0.11

Browser

Firefox

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting and providing the excellent reproduction. I've investigated and the problem does not only happen for notes. There are still some text boxes running out of their containing rectangles (see second graph taken from our docs), and after fiddling a little with it, I don't think that we can solve this problem on our side:

Bildschirmfoto 2023-02-08 um 16 03 04

Luckily, there's a good upstream candidate that was merged 3 weeks ago and waits for a release. Let's see if that fixes the issue. Regardless, this must really be fixed upstream. Related:

@squidfunk squidfunk added bug Issue reports a bug upstream Issue must be taken upstream labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug upstream Issue must be taken upstream
Projects
None yet
Development

No branches or pull requests

2 participants