Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style regression in left menu navigation #4985

Closed
4 tasks done
jmcx opened this issue Feb 3, 2023 · 3 comments
Closed
4 tasks done

Minor style regression in left menu navigation #4985

jmcx opened this issue Feb 3, 2023 · 3 comments
Labels
resolved by customization Issue can be solved through customization

Comments

@jmcx
Copy link

jmcx commented Feb 3, 2023

Bug description

We are running mkdocs-material-8.5.8.

Our current left-menu looks like this:

left-menu-orig

When upgrading to 9.0.3, we're seeing a bad style in left menu navigation, with some entries greyed out. It appears that greyed out entries are those that don't have any content (are only containers for more menu items).

left-menu-issue

Could this be related to "Improved discernability of section index pages in navigation" in 9.0.3?

We are using the index pages feature, but not all of the entries have an index page.

Here is the relevant mkdocs.yaml section

theme:
  name: material
  favicon: assets/images/favicon.ico
  logo: assets/images/tmLogo-white.png
  custom_dir: docs/overrides
  analytics:
    gtag: G-V4SM2FT345
  features:
  - content.code.annotate
  - content.tabs.link
  - navigation.indexes
  - navigation.tabs.sticky
  - navigation.top
  - navigation.tracking

In fact we are open source, you can see our entire docs source here: https://github.com/triggermesh/docs/blob/main/mkdocs.yml

I have tried deactivating any custom styling, that didn't solve it either.

Do you know if there are any workarounds to avoid this? We'd love to update to latest.

Related links

Reproduction

...

Steps to reproduce

...

Browser

No response

Before submitting

@jmcx jmcx changed the title Style regression in left menu navigation Minor style regression in left menu navigation Feb 3, 2023
@squidfunk
Copy link
Owner

squidfunk commented Feb 3, 2023

Thanks for reporting. This is an intended change. See #4832 + comments. If you wish to revert to the previous behavior, the easiest way is to add the following additional CSS:

.md-nav__link[for] {
  color: var(--md-default-fg-color) !important
}

@squidfunk squidfunk added the resolved by customization Issue can be solved through customization label Feb 3, 2023
@jmcx
Copy link
Author

jmcx commented Feb 4, 2023

Thanks!

@jmcx
Copy link
Author

jmcx commented Feb 4, 2023

Loving the project btw 👏

jmcx added a commit to triggermesh/docs that referenced this issue Feb 24, 2023
protects us against the minor graphical issue described in the below issue if/when we update our version of mkdocs (for now we've pinned the version to an older one).

squidfunk/mkdocs-material#4985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved by customization Issue can be solved through customization
Projects
None yet
Development

No branches or pull requests

2 participants