Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocialPlugin fails to use environment variables #4819

Closed
4 tasks done
jasonren0403 opened this issue Jan 3, 2023 · 3 comments
Closed
4 tasks done

SocialPlugin fails to use environment variables #4819

jasonren0403 opened this issue Jan 3, 2023 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@jasonren0403
Copy link
Contributor

Context

No response

Bug description

Social plugin is not working when using environment variables in plugins.social.cards

Related links

Reproduction

example.zip

Steps to reproduce

set plugins.social.cards to !ENV [CARDS, false], just like what document says, then an Exception is encountered:

AttributeError: 'SocialPlugin' object has no attribute '_image_promises'

An minimum mkdocs.yml should be this:

site_name: Test site

theme:
  name: material

plugins:
  - social:
      cards: !ENV [CARDS, false]
  - search

Browser

Chrome, Safari, Edge, Firefox, Opera

Before submitting

@squidfunk squidfunk added the bug Issue reports a bug label Jan 3, 2023
@squidfunk
Copy link
Owner

Thanks for reporting. It has nothing to do with environment variables but fails when cards: false is set. This is definitely related to the latest performance optimizations, should be an easy fix.

@squidfunk
Copy link
Owner

Fixed in c8fb426.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 3, 2023
@squidfunk
Copy link
Owner

Released as part of 9.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants