Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long abbreviations don't wrap to new line in Firefox for Android #4810

Closed
4 tasks done
harry643 opened this issue Jan 2, 2023 · 4 comments
Closed
4 tasks done

Long abbreviations don't wrap to new line in Firefox for Android #4810

harry643 opened this issue Jan 2, 2023 · 4 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@harry643
Copy link

harry643 commented Jan 2, 2023

Context

Device: Samsung Galaxy S10
Android version: 12
Firefox version: 108

Bug description

Long abbreviations extend the entire page width instead of wrapping to new line. Screenshot attached.
long-abbreviation-on-mobile

Related links

Reproduction

example.zip

Steps to reproduce

  1. Create an abbreviation description longer than 100 characters.
  2. Publish the site online.
  3. Access the site via Firefox 108 for Android.
  4. Tap the abbreviation.

Browser

Firefox

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. Abbreviations in the community edition are a hack, as they are implemented using only CSS. Thus, positioning is very limited. I'll investigate whether we can improve the hack, but it will be removed when tooltips are released into the community edition anyway.

Note that this does not happen when tooltips are enabled.

@squidfunk squidfunk added the bug Issue reports a bug label Jan 2, 2023
@squidfunk
Copy link
Owner

Fixed in fbfb662. Abbreviations will now span the entire screen, which is the best thing we can do without JavaScript. As noted, the behavior was improved in Insiders with tooltips, which automatically position to the available screen estate.

Excellent reproduction by the way, made fixing the bug straight forward. Thanks!

Bildschirmfoto 2023-01-02 um 17 08 39

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 2, 2023
@harry643
Copy link
Author

harry643 commented Jan 2, 2023

That was an incredibly quick fix. Thanks so much.

@harry643 harry643 closed this as completed Jan 2, 2023
@squidfunk
Copy link
Owner

Released as part of 9.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants