Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog's title link shouldn't have a subelement in the href #4632

Closed
4 tasks done
hellt opened this issue Nov 14, 2022 · 3 comments
Closed
4 tasks done

Blog's title link shouldn't have a subelement in the href #4632

hellt opened this issue Nov 14, 2022 · 3 comments
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open

Comments

@hellt
Copy link
Contributor

hellt commented Nov 14, 2022

Contribution guidelines

I want to suggest an idea and checked that ...

  • ... to my best knowledge, my idea wouldn't break something for other users
  • ... the documentation does not mention anything about my idea
  • ... there are no open or closed issues that are related to my idea

Description

Latest release of insiders provides a feature to open up the blog page by clicking on the title of the post. This feature request aligns the link href element for a title with the href element of a "Continue reading" link.

Currently, the title link has the format of <site_url>/blog/<post_slug>/#<post_slug> whereas the "Continue reading" element's href is just <site_url>/blog/<post_slug>

Use Cases

Cleaner URL for title link element

Screenshots / Mockups

No response

@squidfunk
Copy link
Owner

Thanks for reporting. Yes, that's suboptimal but that's what thetoc extension gives us. I consider this an optimization.

@squidfunk squidfunk added the change request Issue requests a new feature or improvement label Nov 14, 2022
@squidfunk
Copy link
Owner

Fixed in squidfunk/mkdocs-material-insiders@e7c792c0f.

@squidfunk
Copy link
Owner

Released as part of 8.5.10+insiders-4.26.5.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants