Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are invisible if primary color is white or black #4571

Closed
5 tasks done
tamasgt opened this issue Oct 31, 2022 · 3 comments
Closed
5 tasks done

Buttons are invisible if primary color is white or black #4571

tamasgt opened this issue Oct 31, 2022 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@tamasgt
Copy link

tamasgt commented Oct 31, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Button is wrong if the palette is white.

Expected behaviour

For example, if it is red.

2022-10-31_00-53-07.mp4

Actual behaviour

2022-10-31_00-54-20.mp4

Cookie

2022-10-31_00-58-46.mp4

Steps to reproduce

Just add buttons:

[Subscribe to our newsletter](#){ .md-button }

[Subscribe to our newsletter](#){ .md-button .md-button--primary }

Package versions

mkdocs: 1.4.1
mkdocs-material: 8.5.7+insiders.4.26.1

Configuration

theme:
  name: material
  palette:
    scheme: default
    primary: white

System information

  • Operating system: Windows 10
  • Browser: Chrome
@squidfunk squidfunk added the bug Issue reports a bug label Oct 31, 2022
@squidfunk
Copy link
Owner

Thanks for reporting. Fixed in 3c5f94f.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Nov 1, 2022
@squidfunk squidfunk changed the title Button is wrong if the palette is white. Buttons are invisible if primary color is white or black Nov 1, 2022
@tamasgt
Copy link
Author

tamasgt commented Nov 1, 2022

Thanks for the quick fix!

@squidfunk
Copy link
Owner

Released as part of 8.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants