Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy plugin doesn't fetch Google fonts properly #4514

Closed
5 tasks done
wilhelmer opened this issue Oct 19, 2022 · 2 comments
Closed
5 tasks done

Privacy plugin doesn't fetch Google fonts properly #4514

wilhelmer opened this issue Oct 19, 2022 · 2 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@wilhelmer
Copy link
Contributor

wilhelmer commented Oct 19, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

With the changes introduced in insiders-4.26.0, the privacy plugin doesn't properly fetch the Google fonts anymore.

To reproduce, create a minimal MkDocs project using the mkdocs.yml below. Build and serve the project via mkdocs serve. (The bug does not occur when the project is opened locally, i.e., via file:// protocol)

The fonts aren't rendered properly, and there's an error message in the console:

The stylesheet http://127.0.0.1:8000/assets/external/fonts.googleapis.com/css was not loaded because its MIME type, “application/octet-stream”, is not “text/css”.

Expected behaviour

Fonts should be fetched properly.

Actual behaviour

See description.

Steps to reproduce

See description.

Package versions

  • Python: 3.10.8
  • MkDocs: 1.4.1
  • Material: mkdocs-material-8.5.6-insiders-4.26.0

Configuration

site_name: Test Project
site_url: https://test.com
theme:
    name: material
use_directory_urls: false
nav:
  - Welcome: index.md
plugins:
  - privacy

System information

  • Operating system: macOS Ventura
  • Browser: Firefox
@squidfunk squidfunk added the bug Issue reports a bug label Oct 19, 2022
@squidfunk
Copy link
Owner

squidfunk commented Oct 19, 2022

Thanks for reporting. Should be fixed in squidfunk/mkdocs-material-insiders@7ab6c9de7. It seems that I mixed up the paths, but I wonder that I didn't encounter the error before. Might be related to stale cache on my machine 😅

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Oct 19, 2022
@squidfunk
Copy link
Owner

Released as part of 8.5.7+insiders-4.26.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants