- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Modernize metadata #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize metadata #4341
Conversation
The "Used By" will repopulate within a few days |
Okay, great, thanks! I'll revisit this PR after the blog plugin is out and the dust has settled. Doing two things at once often doesn't pan out great 😉 |
Cool! Is blogging public or insiders? |
The blog plugin will be first released in Insiders, exclusively to sponsors. It's the biggest release this year and it's a great feature to convince more users to support the project by funding it to help make it even better 😊 |
"Used By" is back already fyi
Yup this will be the first time I'll be forced to stop being lazy and set up Insiders! I've just been sponsoring and waiting for many things. |
Ah, hehe, thanks for sponsoring anyway then! I think you'll enjoy using Insiders, as it comes with several niceties. |
] | ||
|
||
[project.entry-points."mkdocs.plugins"] | ||
search = "material.plugins.search.plugin:SearchPlugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the PR to include the social
plugin? It was released as part of 8.5.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
edf84f5
to
80c3654
Compare
Thanks! One final question: Does |
Yup, PEP 660 ( |
Okay perfect. Let's give it another try. Thanks again for your patience! |
@ofek we're having an issue with Insiders. The Node.js plugin doesn't allow for local version identifiers: This means that Insiders can currently not be installed. I need to revert this again for Insiders. |
cc @agoose77 |
@squidfunk this error stems from the fact that currently |
@agoose77 perfect, thanks for the quick response! |
Ah OK, I recall why I made this choice - In Python, local version segments are considered for comparison, whereas in npm they (build segments) are entirely ignored. I suppose that we might allow this, as long as users are aware of the differences. |
Add an option? |
I've released a new version (0.3.0) of the hatchling plugin that should fix this issue according to @ofek You should change the metadata to reflect this version as a lower bound ( |
name = "mkdocs-material" | ||
dynamic = [ | ||
"version", | ||
"dependencies", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofek What does it mean for the dependencies to be dynamic?
mkdocs-material
needs to depend on mkdocs>=1.4.0
, but the installation doesn't ensure this. Is it because of the pip
version, or is there something wrong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex I can answer in part. Any field in pyproject.toml (besides name
) can be dynamic, and it simply means that the build backend (e.g. hatchling) will provide this metadata: https://peps.python.org/pep-0621/#dynamic. My understanding is that the dynamic
field itself is not directly used by PEP 517 frontends, rather it is useful for tools to know whether to ask the backend for metadata rather than just using the pyproject.toml file. @ofek might correct me here, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pyproject.toml
file has dependencies
set to dynamic
, because the requirements_txt
hook populates the depedencies
metadata using https://github.com/squidfunk/mkdocs-material/blob/master/requirements.txt
This fixes #4337 (comment) by implementing the workaround that other large projects have chosen after removing their
setup.py
: