Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version switching does not work with anchors #4291

Closed
5 tasks done
ofek opened this issue Aug 28, 2022 · 3 comments
Closed
5 tasks done

Version switching does not work with anchors #4291

ofek opened this issue Aug 28, 2022 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@ofek
Copy link
Sponsor Collaborator

ofek commented Aug 28, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Version switching does not work with anchors

Expected behaviour

Version switching works with anchors

Actual behaviour

When an anchor is selected, version switching takes you to /

Steps to reproduce

Go to https://hatch.pypa.io/latest/intro/#setup then select any version from the dropdown

Package versions

  • Python: 3.10.5
  • MkDocs: 1.3.1
  • Material: 8.4.2

Configuration

https://github.com/pypa/hatch/blob/master/mkdocs.yml

System information

  • Operating system: Windows 10
  • Browser: Chrome
@squidfunk
Copy link
Owner

Fixed in d0f7301. This was reproducible on the versioning example as well. I redeployed it with the fix:
https://squidfunk.github.io/mkdocs-material-example-versioning/0.3/bar/#bar

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Sep 7, 2022
@squidfunk
Copy link
Owner

Released as part of 8.4.3.

@ofek
Copy link
Sponsor Collaborator Author

ofek commented Sep 7, 2022

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants