Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback widget is not loaded when navigating to another page with navigation.instant feature #4277

Closed
5 tasks done
vedranmiletic opened this issue Aug 24, 2022 · 3 comments
Closed
5 tasks done
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@vedranmiletic
Copy link
Contributor

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Feedback widget is not loaded when navigating to another page with navigation.instant feature. This works as expected without navigation.instant feature.

Expected behaviour

It should be loaded normally.

Actual behaviour

It is not loaded.

Steps to reproduce

  1. Have at least two pages.
  2. Load the first one.
  3. Navigate to the second one.
  4. Observe the missing feedback widget.

Package versions

  • Python: 3.10.6
  • MkDocs: 1.3.1
  • Material: 8.4.1

Configuration

site_name: My Docs
theme:
  name: material
  features:
    - navigation.instant
extra:
  analytics:
    provider: google
    property: G-XXXXXXXXXX
    feedback:
      title: Was this page helpful?
      ratings:
        - icon: material/emoticon-happy-outline
          name: This page was helpful
          data: 1
          note: >-
            Thanks for your feedback!
        - icon: material/emoticon-sad-outline
          name: This page could be improved
          data: 0
          note: >- 
            Thanks for your feedback! Help us improve this page by
            using our <a href="..." target="_blank" rel="noopener">feedback form</a>.

System information

  • Operating system: Garuda Linux
  • Browser: Brave
@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Aug 24, 2022
@squidfunk
Copy link
Owner

Thanks for reporting. Clear oversight on my side, I forgot to test it with instant loading. Fixed in 46d06c1.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Aug 27, 2022
@squidfunk
Copy link
Owner

Released as part of 8.4.2.

@vedranmiletic
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants