Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues related to latest Pygments and Pymdown Extensions #3862

Merged
merged 1 commit into from Apr 30, 2022

Conversation

facelessuser
Copy link
Contributor

Fixes remaining issues related to #3840

@facelessuser
Copy link
Contributor Author

The environment would need to be rebuilt, I didn't want to commit all of that noise.

@squidfunk
Copy link
Owner

Thanks!

@squidfunk squidfunk merged commit f7be5c7 into squidfunk:master Apr 30, 2022
@squidfunk
Copy link
Owner

Unfortunately, there's still some work to do. Tables now have rounded borders in tabs because the hierarchy is entirely different. I need some more time to polish this and wrap it up, but it's tedious work.

@squidfunk
Copy link
Owner

I think I got all cases. There was some regression with rounded borders for full-width code blocks on mobile, and with code blocks nested under tabs. Fixes in bdb5ba5. I need to merge this into Insiders tomorrow, then I can issue a release.

Unfortunately, some selectors need to be overly specific.

@facelessuser
Copy link
Contributor Author

Ah, yeah, I missed that apparently.

@squidfunk
Copy link
Owner

Let's hope the syntax doesn't change again. Code blocks and content tabs and their combinations are quite fragile 😅

@facelessuser
Copy link
Contributor Author

Yeah, I hope they don't change again too. It caught me off gaurd.

@squidfunk
Copy link
Owner

Merge done. Also, 1eeb8b7 removes some more unnecessary stuff. I'll issue a release later or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants