Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color of cluster labels in Mermaid flowcharts #3657

Merged

Conversation

pawamoy
Copy link
Sponsor Contributor

@pawamoy pawamoy commented Mar 2, 2022

See #3618

Without this change, a rule like color: #333 would be applied on clusters labels (.cluster span), making these difficult to read with the dark theme enabled.

I have other files that were modified, I think I should commit them as well (at least the ones already tracked)? Let me know.

 M material/base.html
 M material/overrides/main.html
 M package-lock.json
?? material/assets/javascripts/bundle.js
?? material/assets/javascripts/bundle.js.map
?? material/assets/javascripts/workers/search.js
?? material/assets/javascripts/workers/search.js.map
?? material/assets/stylesheets/main.css
?? material/assets/stylesheets/main.css.map
?? material/assets/stylesheets/palette.css
?? material/assets/stylesheets/palette.css.map
?? material/overrides/assets/javascripts/bundle.js
?? material/overrides/assets/javascripts/bundle.js.map
?? material/overrides/assets/stylesheets/main.css
?? material/overrides/assets/stylesheets/main.css.map

@squidfunk
Copy link
Owner

Thanks for the PR. Please go through the theme build process – it will remove all non-production files (which you currently see in your working copy). Please don't include the package-lock.json.

@squidfunk
Copy link
Owner

Could you please also share the Markdown that this PR fixes?

@pawamoy
Copy link
Sponsor Contributor Author

pawamoy commented Mar 3, 2022

Example flowchart:

```mermaid
flowchart LR

client["client"]
load_balancer["load balancer"]
api1["API (replica 1)"]
api2["API (replica 2)"]
apin["API (replica N)"]

client --- load_balancer
subgraph openshift
    subgraph service
        api1 --- api2 --- apin
    end
    load_balancer --- service
end
```
flowchart LR

client["client"]
load_balancer["load balancer"]
api1["API (replica 1)"]
api2["API (replica 2)"]
apin["API (replica N)"]

client --- load_balancer
subgraph openshift
    subgraph service
        api1 --- api2 --- apin
    end
    load_balancer --- service
end

Before:

chart_before

After:

chart_after

@pawamoy pawamoy force-pushed the fix-mermaid-subgraph-labels-color branch from 4417243 to fe00502 Compare March 3, 2022 18:04
@pawamoy
Copy link
Sponsor Contributor Author

pawamoy commented Mar 3, 2022

I also have:

## fix-mermaid-subgraph-labels-color...origin/fix-mermaid-subgraph-labels-color
 M material/.icons/material/LICENSE
 D material/overrides/assets/javascripts/iconsearch_index.json

LICENSE seems to be CR/LF related. Not sure about the iconsearch_index.json deletion.
Let me know if I should rebase on master or resolve the conflict directly on GitHub.

@pawamoy pawamoy force-pushed the fix-mermaid-subgraph-labels-color branch from fe00502 to 482a16a Compare March 5, 2022 11:36
@squidfunk
Copy link
Owner

Thanks! LGTM!

@squidfunk squidfunk merged commit d023e49 into squidfunk:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants