Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Navigation items appear behind navigation title #3526

Closed
5 tasks done
dimrozakis opened this issue Jan 31, 2022 · 3 comments
Closed
5 tasks done

BUG: Navigation items appear behind navigation title #3526

dimrozakis opened this issue Jan 31, 2022 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@dimrozakis
Copy link

dimrozakis commented Jan 31, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

When the navigation sidebar is scrolled down (requires enough items and short enough window height), the navigation list appears behind the navigation title because the title has a transparent background.

When using 8.1.3-insiders-4.5.0 this did not occur (That's actually not 100% accurate. The > icon for sections would appear behind the navigation title, but the page/section titles would not).

When switching to the latest version, the issue does occur.

Since the website where I'm experiencing this issue contains private information, it's not easy for me to provide screenshots and config files without having to censor things but fortunately I can reproduce this in 3rd party websites of opensource libraries. Please check for example the FastAPI docs https://fastapi.tiangolo.com/tutorial/debugging/ which appears to be using mkdocs-material-8.1.8+insiders-4.6.1.

Expected behaviour

The navigation list items shouldn't be visible behind the navigation title (site title).

Actual behaviour

The navigation items are visible behind the navigation title while scrolling down the navigation sidebar.

Steps to reproduce

https://fastapi.tiangolo.com/tutorial/debugging/

Check at the nav sidebar title on the following screenshot:

Screenshot from 2022-02-01 00-14-28

Package versions

  • Python: python --version: 3.9.6 but seems irrelevant
  • MkDocs: mkdocs --version: 1.2.3
  • Material: pip show mkdocs-material | grep -E ^Version
    • Happens with the latest version 8.1.9-insiders-4.7.1
    • Happens on FastrAPI docs which use 8.1.8+insiders-4.6.1 according to html source.
    • Does NOT happen with 8.1.3-insiders-4.5.0 (but > icons do get displayed!)

Configuration

I haven't actually built the website like this, but since this is reproducible in the FastAPI docs, I suppose this will do https://github.com/tiangolo/fastapi/blob/master/docs/en/mkdocs.yml

System information

  • Operating system: Linux Mint 19.1
  • Browser: I can reproduce with Chromium 97.0.4692.71 & Firefox 96.0.3
@squidfunk squidfunk added bug Issue reports a bug needs investigation Issue must be investigated by the maintainers labels Jan 31, 2022
@squidfunk
Copy link
Owner

squidfunk commented Feb 1, 2022

Thanks for reporting! This is a regression that was introduced in 8.1.4+insiders-4.5.1, which adds some CSS to fix a weird rendering issue in Safari, which in turn was originally reported in #3396. This commit introduced the error you just reported. I think I fixed it in 67e15b3 and adjusted the original bugfix in #3396.

@squidfunk squidfunk added resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Feb 1, 2022
@dimrozakis
Copy link
Author

Thanks @squidfunk. I tried building the website with the master branch of insiders & can confirm that it's working properly. The nav pages/sections don't appear behind the nav sidbar header. Neither do the > nav section icons (which was the case in 8.1.3-insiders-4.5.0).

@squidfunk
Copy link
Owner

The fix was just released as part of 8.1.9-insiders-4.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants