Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline does not link when linked content tab is set. #3440

Closed
5 tasks done
btbf opened this issue Jan 6, 2022 · 8 comments
Closed
5 tasks done

Underline does not link when linked content tab is set. #3440

btbf opened this issue Jan 6, 2022 · 8 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@btbf
Copy link

btbf commented Jan 6, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Underline does not link when linked content tab is set.
(The text inside is linked.)

Expected behaviour

I'd like to see a link to underline as well.

Actual behaviour

screencast-49.12.225.142_8000-2022.01.06-22_44_44.mp4

Steps to reproduce

  1. Add "- content.tabs.link" to mkdocs.yml

Package versions

  • Python: 3.8.10
  • MkDocs: 1.2.3
  • Material: 8.1.4+insiders.4.5.1

Configuration

site_name: My Docs
theme:
  language: ja
  font:
    text: Noto Sans Japanese
  name: material
  palette:
    primary: indigo
  features:
    - content.tabs.link
    - navigation.tabs
    - navigation.tabs.sticky
    - navigation.top
    - navigation.instant




markdown_extensions:
  - codehilite
  - pymdownx.superfences:
      custom_fences:
        - name: mermaid
          class: mermaid
          format: !!python/name:pymdownx.superfences.fence_div_format
  - admonition
  - pymdownx.details
  - pymdownx.superfences
  - pymdownx.tabbed:
      alternate_style: true 

extra_javascript:
  - https://unpkg.com/mermaid@8.5.1/dist/mermaid.min.js


#extra_css:
  - stylesheets/extra.css

nav:
    - Home: '../'
    - 'Pool Setup':
      - '0.はじめに': './pool-setup/start-guide.md'
      - '1.Ubuntu初期設定': './pool-setup/ubuntu-setup.md'
      - '2.ノードセットアップ': './pool-setup/node-setup.md'

System information

  • Operating system: Ubuntu 20.04
  • Browser: Google Chrome 96.0.4664.110
@squidfunk squidfunk added the bug Issue reports a bug label Jan 6, 2022
@squidfunk
Copy link
Owner

Thanks for reporting - indeed, the indicator should work for linked tabs.

@squidfunk
Copy link
Owner

Fixed in bd4b472. Also see #3445 (comment).

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 7, 2022
@squidfunk
Copy link
Owner

Released as part of 8.1.4-insiders-4.5.2.

@btbf
Copy link
Author

btbf commented Jan 8, 2022

Thank you for your support.
I updated Insider, and the bug was fixed, but the version information was still the same as in 4.5.1.
image

@squidfunk
Copy link
Owner

I'm sorry, I forgot to bump the version. I do a re-release tomorrow.

@squidfunk
Copy link
Owner

mkdocs-material-8.1.5+insiders-4.5.2 was just released.

@xihajun
Copy link

xihajun commented Dec 21, 2022

May I kindly ask how to install mkdocs-material insiders?

pip install mkdocs-material-8.1.5+insiders-4.5.2?

@squidfunk
Copy link
Owner

squidfunk commented Dec 21, 2022

@xihajun you need to become a sponsor, will then be invited to a private repository and can then install it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

3 participants