Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flex footer causing ellipsis overflow #3302

Closed
5 tasks done
baileyherbert opened this issue Dec 5, 2021 · 7 comments
Closed
5 tasks done

New flex footer causing ellipsis overflow #3302

baileyherbert opened this issue Dec 5, 2021 · 7 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@baileyherbert
Copy link

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

The "next" and "previous" links in the footer are ellipting with the new flex footer regardless of how short they are.

Expected behaviour

"Classes"

image

Actual behaviour

"Class..."

image

Steps to reproduce

Reproducible on a fresh setup with minimal config

Package versions

  • Python: 3.10.0
  • MkDocs: 1.2.3
  • Material: 8.0.4+insiders.4.3.0

Configuration

theme:
  name: material
  features:
    - navigation.top
    - navigation.tracking
    - navigation.sections

site_name: Test

nav:
  - Introduction: index.md
  - Classes: classes.md

System information

  • Operating system: Win11
  • Browser: Chrome (latest stable)
@squidfunk
Copy link
Owner

squidfunk commented Dec 5, 2021

Thanks for reporting. I'm not able to reproduce this in Chrome, macOS. Firefox works as well. However, Safari also shows the ellipsis.

@squidfunk squidfunk added the bug Issue reports a bug label Dec 5, 2021
@baileyherbert
Copy link
Author

Thanks @squidfunk, can confirm that it's working normally in Firefox from here, it's just Chrome/Edge for me and I can see it on your official docs too. Boy do I hate flexboxes! 🤣

Cheers!

@squidfunk
Copy link
Owner

Potential fix in 37e6f43.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Dec 5, 2021
@baileyherbert
Copy link
Author

Yup, it's working perfectly now! Thank you! ❤️

@squidfunk
Copy link
Owner

Let's leave this open until it's released 😊

@squidfunk squidfunk reopened this Dec 5, 2021
@squidfunk
Copy link
Owner

squidfunk commented Dec 6, 2021

We can in fact close this since it happened after the 8.0.4. release, so it's not a regression as the changes inducing the bug reported were not released in the first place. Thus, no bugfix release to be made 😉

Ah or wait, no, Insiders included the changes 😁 Argh. Okay, so I'll release them as 8.0.5. in a few minutes.

@squidfunk
Copy link
Owner

squidfunk commented Dec 6, 2021

Released as part of 8.0.5+insiders-4.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants