Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0.0 regression: extra margin in admonitions #3265

Closed
5 tasks done
fottsia opened this issue Nov 28, 2021 · 6 comments
Closed
5 tasks done

8.0.0 regression: extra margin in admonitions #3265

fottsia opened this issue Nov 28, 2021 · 6 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@fottsia
Copy link

fottsia commented Nov 28, 2021

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

After updating to 8.0.0, admonitions that are inside links have extra margin in their titles.

Expected behaviour

They shouldn't have extra margin.

Actual behaviour

And yet they do.

Steps to reproduce

Create a list and an admonition inside it, with material 8.0.0.

Package versions

  • Material: 8.0.0

Configuration

...

System information

  • Operating system: Ubuntu 20.04
  • Browser: Firefox
@squidfunk
Copy link
Owner

Already fixed in 8fa834f.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Nov 28, 2021
@squidfunk
Copy link
Owner

Released as part of 8.0.1

@rachel-rigdon-sp
Copy link
Contributor

@squidfunk I'm seeing this error again in 8.1.1. It works when I'm running 8.0.1 but reintroduces the extra margin if I update to 8.1.1.

@alkisg
Copy link
Contributor

alkisg commented Dec 14, 2021

We too have the same issue with 8.1.1, for example here.

@squidfunk
Copy link
Owner

Thanks for reporting. I refactored the CSS to reduce specificity in 8.1.0 and 8.1.1. Fixed in be24342.

@squidfunk
Copy link
Owner

Released as part of 8.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

4 participants