Feedback feature does not work on safari

[garrettheel]

Contribution guidelines

• I've read the contribution guidelines and wholeheartedly agree

I've found a bug and checked that ...

• ... the problem doesn't occur with the mkdocs or readthedocs themes
• ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem

Description

The new "Was this page helpful" feature does not work on Safari.

When clicking a button, the following error is logged to the console:

TypeError: null is not an object (evaluating 'e.submitter.getAttribute')

Per https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent/submitter, SubmitEvent.submitter is not compatible with IE or Safari.

Expected behaviour

Expect the button to submit the feedback.

Actual behaviour

No feedback and a JS console error.

Steps to reproduce

Use the Safari browser to submit feedback.

Package versions

• Material: 7.3.6+insiders.3.1.5

Configuration

n/a

System information

n/a

[squidfunk]

Thanks for reporting! Fixed in 45b6801. I was naive to assume something as modern as FormEvent.submitter being available on all modern platforms 😉

[squidfunk]

Released as part of 7.3.6-insiders-3.2.1.