Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub stats not provided anymore for users / organizations #3069

Closed
5 tasks done
kcgthb opened this issue Oct 1, 2021 · 3 comments
Closed
5 tasks done

GitHub stats not provided anymore for users / organizations #3069

kcgthb opened this issue Oct 1, 2021 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@kcgthb
Copy link
Contributor

kcgthb commented Oct 1, 2021

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

It looks like the feature introduced in #342 to allow getting user/org stats from GitHub (when the repo_url in mkdosc.yml is a user/organization URL rather than a repo URL) is not working anymore.

With this in mkdocs.yml:

repo_url:  https://github.com/orgname

the requested API URL (captured in the browser's Developer Tools) is https://api.github.com/repos/orgname instead of https://api.github.com/users/orgname.

Expected behaviour

GitHub user/org stats are fetched from https://api.github.com/users/name

Actual behaviour

GitHub user/org stats are fetched from https://api.github.com/repos/name

Steps to reproduce

  1. Set a user or organization URL as repo_url in mkdocs.yml
  2. render the pages
  3. no GitHub stats are provided

Package versions

  • Python: 3.9.7
  • MkDocs: 1.2.2
  • Material: 7.3.0

Configuration

repo_url:  https://github.com/orgname

System information

  • Operating system: Linux
  • Browser: tested with up to date versions of Firefox, Chrome, Brave
@squidfunk
Copy link
Owner

Thanks for reporting. Fixed in ef0979f.

It's a regression since 7.1.0, as it broke 6 months ago when the merge related to the 'Black Pearl' funding goal was done.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Oct 1, 2021
@kcgthb
Copy link
Contributor Author

kcgthb commented Oct 1, 2021

Fantastic, thank you for the quick fix!

@squidfunk
Copy link
Owner

Released as part of 7.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants