Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC points to Search on latest version, for mobile #3039

Closed
5 tasks done
cmitu opened this issue Sep 20, 2021 · 8 comments
Closed
5 tasks done

TOC points to Search on latest version, for mobile #3039

cmitu opened this issue Sep 20, 2021 · 8 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@cmitu
Copy link

cmitu commented Sep 20, 2021

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

On mobile, the TOC link opens the search page, instead of the actual TOC. Behavior noticed with 7.2.7, but not with 7.2.6.

Expected behaviour

The TOC link should open the Table of Contents.

Actual behaviour

Clicking on the TOC link on the top left opens the search dialog instea of showing the TOC.

image

Steps to reproduce

Browse https://retropie.org.uk/docs/ from a mobile or using the dev tools of the browser and force a mobile user-agent.

Package versions

  • Python: 3.7
  • MkDocs: 1.2.2
  • Material: 7.27

Configuration

See https://github.com/RetroPie/RetroPie-Docs/blob/master/mkdocs.yml
The entire site is kept at https://github.com/RetroPie/RetroPie-Docs/ and can be easily cloned and displayed locally with `mkdocs serve`.

System information

  • Operating system: Windows/iOS/Linux
  • Browser: Safari (iOS iOS 14.7), Firefox latest (92.0, Windows/Linux)
@squidfunk
Copy link
Owner

squidfunk commented Sep 20, 2021

Thanks for reporting. Definitely a 7.2.7 regression.

Temporary workaround: downgrade to 7.2.6

@squidfunk squidfunk added the bug Issue reports a bug label Sep 20, 2021
@squidfunk
Copy link
Owner

Ah wait, probably an easy fix:

.md-search__inner {
  overflow: hidden;
}

Does that solve the issue for you?

@cmitu
Copy link
Author

cmitu commented Sep 20, 2021

Yes, the above rule seems to work.
EDIT: it may affect the search box though (even on non-mobile). I don't see the search results with this rule added.

@squidfunk
Copy link
Owner

Yes, it's must only be applied for the mobile view.

@squidfunk
Copy link
Owner

2eabc94 fixes the issue.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Sep 20, 2021
@squidfunk
Copy link
Owner

Could you check the latest master? if you can confirm that it works now, I can issue a bugfix release shortly.

@cmitu
Copy link
Author

cmitu commented Sep 20, 2021

Yes, master works fine now (no issues with search also).
Thank you for the fast fix !

@squidfunk
Copy link
Owner

Released as part of 7.2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants