Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in 7.x for image alignment #2337

Closed
lazka opened this issue Feb 24, 2021 · 5 comments · Fixed by aws/jsii#2693, hacf-fr/awesome-francophone-home-assistant#106 or JosephMontoya-TRI/BEEP#3
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@lazka
Copy link

lazka commented Feb 24, 2021

Maybe it is on purpose, I thought I'd report anyway.

Old: https://web.archive.org/web/20201028041546if_/https://squidfunk.github.io/mkdocs-material/reference/images/#image-alignment

New: https://squidfunk.github.io/mkdocs-material/reference/images/#image-alignment

Caused by flow-root in 9591265

One workaround I found was adding the image to the same paragraph and using <br> everywhere so there is only one paragraph.

@squidfunk
Copy link
Owner

Thanks for reporting - definitely a bug!

@squidfunk squidfunk added the bug Issue reports a bug label Feb 24, 2021
@squidfunk
Copy link
Owner

squidfunk commented Feb 24, 2021

Fixed in a17b637 together with #2336.

flow-root is pretty tricky. We need it for positioning of inline elements (i.e. inline admonitions), but I think setting it on paragraphs is not a good idea, which is why I removed it from paragraphs. I added it for figures, though, so they render nicely next to inline admonitions. Let's see if it introduces new problems.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Feb 24, 2021
@lazka
Copy link
Author

lazka commented Feb 24, 2021

Thanks!

@squidfunk
Copy link
Owner

I'll issue 7.0.1 later this day, I've some other small changes in the pipe.

@squidfunk
Copy link
Owner

Released as part of 7.0.1.

This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment