-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup of source facts no longer works with GitHub organisation #1864
Comments
You're right, this got lost somehow in the v5 rewrite and is definitely a bug. Should be quite easy to fix, though. |
Turns out, it's only a bug in the regex. The second capturing group missed a |
Released as part of 5.5.6. |
@squidfunk I just noticed that the repo stats are no longer displayed (stars, forks). Is this related to this change? Oh looks like I hit the API rate limit: |
The results from the GitHub API call are persisted in session storage (not local storage), so it's per browser tab/session. If you open and close your browser too often, you get 429ed by GitHub 😅 |
Yeah I need to calm down 😅 |
Description
If
repo_url
points to a GitHub organisation no source facts are retrieved. Looking in the js console, there's a 404 error as the theme is requesting the organisation name from the GitHubrepos
endpointExpected behavior
The number of repositories belonging to the organisation should be displayed under the repository name. This is what happened in earlier versions.
Actual behavior
No source facts are displayed.
Steps to reproduce the bug
repo_url
to a GitHub organisation urlPackage versions
The text was updated successfully, but these errors were encountered: