Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe height is not adjustable #1664

Closed
1 task
wgoetz opened this issue May 2, 2020 · 3 comments
Closed
1 task

iframe height is not adjustable #1664

wgoetz opened this issue May 2, 2020 · 3 comments
Labels
bug Issue reports a bug

Comments

@wgoetz
Copy link

wgoetz commented May 2, 2020

my quick fix: removed the iframe... height=auto from main.c4007cdc.min.css

maybe you should have separate settings for iframe and img/svg
(_typeset.scss)

root cause probably this commit:
commit e6143e7
Author: squidfunk martin.donath@squidfunk.com
Date: Mon Apr 27 09:34:49 2020 +0200

Fixed distorted image when width and height are explicitly set

I checked that...

  • [x ] ... the documentation does not mention anything about my problem
  • ... the problem doesn't occur with the default MkDocs template
  • [x ] ... the problem is not in any of my customizations (CSS, JS, template)
  • [ x] ... there are no open or closed issues that are related to my problem

Description

iframes, such as embedded google calendar or the selfhtml example have a fixed height.
not adjustable.

Expected behavior

want freely adjust the height!

Actual behavior

fixed height

Steps to reproduce the bug

from https://wiki.selfhtml.org/wiki/Beispiel:HTML_iframe-Element-seamless.html

<iframe src="https://wiki.selfhtml.org/wiki/Startseite" seamless width="90%" height="400" name="SELFHTML_in_a_box"></iframe>

Package versions

  • Python: python --version
    Python 3.6.9

  • MkDocs: mkdocs --version
    kdocs, version 1.1 from /home/goetz/virtualenv/p3mai/lib/python3.6/site-packages/mkdocs (Python 3.6)

  • Material: pip show mkdocs-material | grep -E ^Version
    Version: 5.1.4

Project configuration

The contents of your mkdocs.yml

System information

  • OS: ...
  • Browser: ...
@squidfunk
Copy link
Owner

I guess we can remove height: auto for iframes.

@squidfunk squidfunk added the bug Issue reports a bug label May 2, 2020
@squidfunk
Copy link
Owner

Fixed in 52c3daf.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label May 3, 2020
@squidfunk
Copy link
Owner

Released as part of 5.1.5.

@squidfunk squidfunk removed the resolved Issue is resolved, yet unreleased if open label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug
Projects
None yet
Development

No branches or pull requests

2 participants